Skip to content

fix: Remove bogus comment #2585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2023
Merged

fix: Remove bogus comment #2585

merged 1 commit into from
Jan 25, 2023

Conversation

metabiswadeep
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2023

Codecov Report

Merging #2585 (060bfd8) into main (c4e546d) will increase coverage by 0.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2585      +/-   ##
==========================================
+ Coverage   82.51%   82.64%   +0.12%     
==========================================
  Files         598      598              
  Lines        9874     9874              
  Branches     1354     1354              
==========================================
+ Hits         8148     8160      +12     
+ Misses       1384     1370      -14     
- Partials      342      344       +2     
Flag Coverage Δ
longtests 82.17% <ø> (+0.12%) ⬆️
win-longtests 75.07% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/test_scanner.py 76.21% <ø> (ø)
cve_bin_tool/cli.py 68.16% <0.00%> (+0.32%) ⬆️
cve_bin_tool/data_sources/nvd_source.py 61.29% <0.00%> (+4.43%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry I missed this in code review.

@terriko
Copy link
Contributor

terriko commented Jan 25, 2023

Note: test fails here are unrelated, NVD is apparently rate limiting our schema checks and we maybe need to look into whether we need to send an API key with those.

@terriko terriko merged commit 1162c19 into intel:main Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants